| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)
Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp:100:9 index
Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar
With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.
Test: mmm packages/inputmethods/LatinIME, presubmit check.
Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: Jing Mike <jingyangliu@eswincomputing.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added SPDX-license-identifier-Apache-2.0 to:
Android.bp
common/Android.bp
java/Android.bp
native/dicttoolkit/Android.bp
native/jni/Android.bp
tests/Android.bp
tools/EditTextVariations/Android.bp
tools/dicttool/Android.bp
tools/make-keyboard-text/Android.bp
Bug: 68860345
Bug: 151177513
Bug: 151953481
Test: m all
Exempt-From-Owner-Approval: janitorial work
Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This will ensure that the target stays green.
Note: we will clean up the explicit unit_tests:true once cc_test default is changed.
Change-Id: I5153ca918e94b370b1f08289118877d209385ba2
Test: presubmit
Bug: 180014759
|
|/
|
|
|
|
| |
Change-Id: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Merged-In: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Fixes: 180014759
Test: atest liblatinime_unittests --host
|
|
|
|
|
|
|
|
| |
See https://source.android.com/setup/contribute/respectful-code for reference
Bug: 161896447
Test: tapas LatinIME && m
Change-Id: Ic06f948c023a091e1532db826a78dd01031d7205
|
|
|
|
|
|
|
| |
See https://source.android.com/setup/contribute/respectful-code for reference
Bug: 161896447
Change-Id: I171bc299e660f96f20041a67a3052bd8a2ed781c
|
|
|
|
|
|
|
|
| |
Preparation for removing implicit include paths for jni.h from soong.
Bug: 152482542
Test: lunch aosp_x86_64 && m checkbuild
Change-Id: Ib36e679819a3309ccbf12fd592309b16c8bbd6c8
|
|\
| |
| |
| |
| |
| | |
am: d894eec1ee
Change-Id: Ib7cdb0007c22934f7736cd02c02e0f9358f889d4
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This app is frequently overriden by proprietary apps
on shipping devices, so move it to /product along with
its jni library.
Bug: 122353713
Test: launch keyboard on aosp_arm64 emulator
Change-Id: Ied8c1e6133b67e28da76b0e48254e2e2e0ed15bf
|
|\|
| |
| |
| |
| |
| | |
am: 535cd61e63
Change-Id: Ic8ee8523a644b283ef0c9592bb66bf09ca541485
|
| |
| |
| |
| |
| |
| | |
Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: I06021a6597705515dc7a3cb81a7fbbac7ba344a1
|
| |
| |
| |
| |
| |
| |
| |
| | |
See build/soong/README.md for more information.
Test: cd packages/inputmethods/LatinIME; mma
Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
|
| |
| |
| |
| |
| |
| |
| | |
See build/soong/README.md for more information.
Test: cd packages/inputmethods/LatinIME; mma
Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
|
|\|
| |
| |
| |
| |
| |
| |
| | |
61d3a1d39b am: 587239f195
am: 9c58fe67f0
Change-Id: I926433188e61eef7f4947167e51b1afae407d9fc
|
| |
| |
| |
| |
| |
| | |
Bug: 116614593
Test: build with WITH_TIDY=1
Change-Id: Ic2a04f82f36c2f7fe43109a7a74270044d227789
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This CL addresses compiler warnings when building libjni_latinime.so
with NDK from Android Studio.
There should be no behavior change.
Bug: 110741422
Bug: 110757803
Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
Change-Id: Icc711dd46511a167b1fd90028552def5b2f9941f
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Host-side C++ test in LatinIME is no longer actively used and is
actually not compatible with Android Studio build.
Let's just remove this for now.
Bug: 13754552
Bug: 110741422
Test: compile
Change-Id: I3e81285fe559022e1a296051036e74d2f2afbf9c
|
|
|
|
|
|
| |
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I6b91302908e147077bb4fd0a8718c39357337133
|
|
|
|
|
|
|
|
| |
* Suppress warning on unused loop index variable.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ia3f0f9cc4cb0ebeeac9b1ff51955597a725c87ef
|
|
|
|
|
|
|
| |
clang is the default compiler since Android nougat
Change-Id: I52d7f1ded227b21cd88d2d292f0af4adecb800f4
Signed-off-by: Lennart Wieboldt <lennart.1997@gmx.de>
|
|
|
|
|
|
| |
Bug: http://b/32019064
Test: builds
Change-Id: I17611b6d9598992bd52cf3dc93509f0f5e0bdcde
|
|
|
|
|
|
|
|
|
| |
The library was being built with the NDK, but the test is being built
with the platform, in this case building against the NDK STL headers
and then using the platform library, which are not ABI compatible.
Bug: http://b/27801981
Change-Id: I7386dfe6ac73334d7c1b1e0cbc8dc346c84313bf
|
|\
| |
| |
| |
| | |
* commit '9ce2d0bb3702f2854e612cb743f4c508dd590981':
Remove uses of libcxx.mk.
|
| |
| |
| |
| |
| |
| | |
This is a no-op.
Change-Id: I982883f994303ba622546b5c6cd0e935a354cde8
|
| |
| |
| |
| |
| | |
Bug: 18725954
Change-Id: Ia442ba4b5d84311057d83edf6e7aeb151d6a820b
|
| |
| |
| |
| |
| | |
Bug: 18725954
Change-Id: I3c823fda1b7daf41d82b118d9495f5f2356a1a5e
|
| |
| |
| |
| |
| | |
Bug: 18725954
Change-Id: I8fcb0d15dda3f823a4575fe707bcdec57ff5e89b
|
| |
| |
| |
| |
| | |
Bug: 18725954
Change-Id: Ic97d3a56b036ff042322c9f794504064046fd7d7
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
Bug: 7677193
Change-Id: I66eddbf27a9db8682c0347a1be19922792a3bea7
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before:
Total words: 1134659, Success Num: 944709, Success Percentage: 83.259%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28013, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3347332, Keystroke Saving Percentage:44.880%
After:
Total words: 1134665, Success Num: 945026, Success Percentage: 83.287%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1271, Bad Failure Percentage: 0.112%
Failures, with auto-correction (F-C): 27756, F-C Percentage: 2.446%
Max Keystrokes: 6072850, Min Keystrokes: 3290996, Keystroke Saving Percentage:45.808%
Change-Id: I16af52a3e9c371b95fd6f0741f45ee6b2443bea6
|
| |
| |
| |
| | |
Change-Id: Ie28768ceadcd7a2d940c57eb30be7d4c364e509f
|
| |
| |
| |
| |
| | |
Bug: 18436480
Change-Id: Ic92cae7c85c07c8f62a5b6e69d2b71e204aff50d
|
| |
| |
| |
| |
| |
| | |
This reverts commit 64d3f78ee5d9dabf7df6106241dfae3334b34714 per https://android-review.googlesource.com/114664
Change-Id: I2acab828d41e79847db72f8d2677c12173a323b6
|
| |
| |
| |
| |
| |
| |
| | |
Looks like unbundled builds need to use --hash-style=sysv for the
sake of compatibility
Change-Id: Ia7b3a1cc3b2c91a8628551888a74925926dff855
|
| |
| |
| |
| |
| | |
Bug: 10059681
Change-Id: Ic29e79d049bb532727cf5cb1e529fec5d35156ed
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Change-Id: Idf03e97661d64186c752e35964d641a5528be5b1
|
|/ /
| |
| |
| |
| | |
Bug: 17797064
Change-Id: Ie992c9454edfc3bf93d5ea367c3a4427b513a205
|
| |
| |
| |
| | |
Change-Id: Ib69569ab6b6edfcc8c1d2c621b95de4127789ab6
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%
Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%
After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%
Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
|
|\| | |
|
| | |
| | |
| | |
| | |
| | | |
Bug: 14425059
Change-Id: Ib050574aa7c4babd4285322a11c3af9be9fbab1e
|
|\| | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
count -> 2B, level -> 0B.
Change-Id: I3b241126f56eb33cdf09cb1ebfed04f534e4ec48
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, when both legitimate 0-frequency words (such as
distracters) and offensive words were encoded in the same
way, distracters would never show up when the user blocked
offensive words (the default setting, as well as the setting
for regression tests).
When b/11031090 was fixed and a separate encoding was used
for offensive words, 0-frequency words would no longer be
blocked when they were an "exact match" (where case
mismatches and accent mismatches would be considered an
"exact match"). The exact match boosting functionality meant
that, for example, when the user typed "mt" they would be
suggested the word "Mt", although they most probably meant
to type "my".
For this reason, we introduced this change, which does the
following:
* Defines the "perfect match" as a really exact match, with
no room for case or accent mismatches
* When the target word has probability zero (as "Mt" does,
because it is a distracter), ONLY boost its score if it is a
perfect match.
By doing this, when the user types "mt", the word "Mt" will
NOT be boosted, and they will get "my". However, if the user
makes an explicit effort to type "Mt", we do boost the word
"Mt" so that the user's input is not autocorrected to "My".
Bug: 11031090
Change-Id: I92ee1b4e742645d52e2f7f8c4390920481e8fff0
|