| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)
Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp:100:9 index
Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar
With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.
Test: mmm packages/inputmethods/LatinIME, presubmit check.
Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: Jing Mike <jingyangliu@eswincomputing.com>
|
|
|
|
|
|
|
|
| |
See https://source.android.com/setup/contribute/respectful-code for reference
Bug: 161896447
Test: tapas LatinIME && m
Change-Id: Ic06f948c023a091e1532db826a78dd01031d7205
|
|
|
|
|
|
|
| |
See https://source.android.com/setup/contribute/respectful-code for reference
Bug: 161896447
Change-Id: I171bc299e660f96f20041a67a3052bd8a2ed781c
|
|\
| |
| |
| |
| |
| | |
am: 535cd61e63
Change-Id: Ic8ee8523a644b283ef0c9592bb66bf09ca541485
|
| |
| |
| |
| |
| |
| | |
Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: I06021a6597705515dc7a3cb81a7fbbac7ba344a1
|
|\|
| |
| |
| |
| |
| |
| |
| | |
61d3a1d39b am: 587239f195
am: 9c58fe67f0
Change-Id: I926433188e61eef7f4947167e51b1afae407d9fc
|
| |
| |
| |
| |
| |
| | |
Bug: 116614593
Test: build with WITH_TIDY=1
Change-Id: Ic2a04f82f36c2f7fe43109a7a74270044d227789
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This CL addresses compiler warnings when building libjni_latinime.so
with NDK from Android Studio.
There should be no behavior change.
Bug: 110741422
Bug: 110757803
Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
Change-Id: Icc711dd46511a167b1fd90028552def5b2f9941f
|
|
|
|
|
| |
Bug: 18725954
Change-Id: Ia442ba4b5d84311057d83edf6e7aeb151d6a820b
|
|
|
|
|
| |
Bug: 18725954
Change-Id: I3c823fda1b7daf41d82b118d9495f5f2356a1a5e
|
|
|
|
|
| |
Bug: 18725954
Change-Id: I8fcb0d15dda3f823a4575fe707bcdec57ff5e89b
|
|
|
|
|
| |
Bug: 18725954
Change-Id: Ic97d3a56b036ff042322c9f794504064046fd7d7
|
|\ |
|
| |
| |
| |
| |
| | |
Bug: 7677193
Change-Id: I66eddbf27a9db8682c0347a1be19922792a3bea7
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
Total words: 1134659, Success Num: 944709, Success Percentage: 83.259%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28013, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3347332, Keystroke Saving Percentage:44.880%
After:
Total words: 1134665, Success Num: 945026, Success Percentage: 83.287%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1271, Bad Failure Percentage: 0.112%
Failures, with auto-correction (F-C): 27756, F-C Percentage: 2.446%
Max Keystrokes: 6072850, Min Keystrokes: 3290996, Keystroke Saving Percentage:45.808%
Change-Id: I16af52a3e9c371b95fd6f0741f45ee6b2443bea6
|
|
|
|
| |
Change-Id: Ie28768ceadcd7a2d940c57eb30be7d4c364e509f
|
|
|
|
|
| |
Bug: 18436480
Change-Id: Ic92cae7c85c07c8f62a5b6e69d2b71e204aff50d
|
|
|
|
|
| |
Bug: 10059681
Change-Id: Ic29e79d049bb532727cf5cb1e529fec5d35156ed
|
|\ |
|
| |
| |
| |
| | |
Change-Id: Idf03e97661d64186c752e35964d641a5528be5b1
|
|/
|
|
|
| |
Bug: 17797064
Change-Id: Ie992c9454edfc3bf93d5ea367c3a4427b513a205
|
|
|
|
| |
Change-Id: Ib69569ab6b6edfcc8c1d2c621b95de4127789ab6
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%
Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%
After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%
Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
|
|\| |
|
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: Ib050574aa7c4babd4285322a11c3af9be9fbab1e
|
|\| |
|
| |
| |
| |
| |
| |
| | |
count -> 2B, level -> 0B.
Change-Id: I3b241126f56eb33cdf09cb1ebfed04f534e4ec48
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when both legitimate 0-frequency words (such as
distracters) and offensive words were encoded in the same
way, distracters would never show up when the user blocked
offensive words (the default setting, as well as the setting
for regression tests).
When b/11031090 was fixed and a separate encoding was used
for offensive words, 0-frequency words would no longer be
blocked when they were an "exact match" (where case
mismatches and accent mismatches would be considered an
"exact match"). The exact match boosting functionality meant
that, for example, when the user typed "mt" they would be
suggested the word "Mt", although they most probably meant
to type "my".
For this reason, we introduced this change, which does the
following:
* Defines the "perfect match" as a really exact match, with
no room for case or accent mismatches
* When the target word has probability zero (as "Mt" does,
because it is a distracter), ONLY boost its score if it is a
perfect match.
By doing this, when the user types "mt", the word "Mt" will
NOT be boosted, and they will get "my". However, if the user
makes an explicit effort to type "Mt", we do boost the word
"Mt" so that the user's input is not autocorrected to "My".
Bug: 11031090
Change-Id: I92ee1b4e742645d52e2f7f8c4390920481e8fff0
|
|
|
|
|
|
|
|
|
| |
If the user has chosen to block offensive words and types
"aaaxbb", where "aaa" is an offensive word and "bb" is not,
we should not suggest "aaa bb".
Bug: 11031090
Change-Id: Ie23b8dd5d347bc26b1c046c3f5e8dfbc259bf528
|
|
|
|
|
| |
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
|
|
|
|
|
|
| |
Bug: 14425059
Change-Id: Icc15e14cfd77d37cd75f75318fd0fa36f9ca7a5b
|
|
|
|
|
| |
Bug: 14425059
Change-Id: Ia58ab3f0ead02798046d182a9464dcbd95f086bc
|
|
|
|
|
| |
Bug: 14425059
Change-Id: I3e5d359ba5fa38f1669f0e98dfae792ff53efbf8
|
|
|
|
| |
Change-Id: I1697a907562d1ed6aff2b001763d1594263ba0d3
|
|\ |
|
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: I08ec19903432356b6028853fd73b4eefce20218e
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bug: 17432052
[Category diff]
+1 262
-1 93
+2 2
-2 18
+3 18
-3 2
+4 111
-4 148
+5 295
-5 217
+6 51
-6 276
+7 139
-7 124
[Weighted category diff]
+1 276
-1 100
+2 4
-2 20
+3 20
-3 4
+4 118
-4 160
+5 309
-5 225
+6 52
-6 298
+7 163
-7 135
show diff for ./en_user_log_phones_2011_08.csv
+1 173
-1 28
+2 2
-2 17
+3 17
-3 2
+4 63
-4 82
+5 120
-5 51
+6 24
-6 220
+7 88
-7 87
Change-Id: I9d673acb0ff632828ae2e0ead56e76e3a20411c6
|
|/
|
|
|
|
|
| |
If a word is once deleted, the word never gets into the
personalized dictionaries due to this bug.
Change-Id: Ife4e3fe1ba0615b4135e6291d2151b0db7d3f940
|
|
|
|
|
| |
Bug: 14425059
Change-Id: I45ae00069dd3b7c461dd9a1f3558b96af0a1c975
|
|
|
|
|
| |
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
|
|
|
|
|
| |
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
|
|
|
|
|
| |
Bug: 14425059
Change-Id: I98cb9fa303af2d93a0a3512e8732231c564e3c5d
|
|
|
|
| |
Change-Id: Id94636714d04a8828718b87741c0ee62a14cb3b4
|
|\
| |
| |
| |
| |
| | |
* changes:
Make NgramProperty have NgramContext.
Create .cpp file for NgramContext.
|
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: I210acb816b122857dbbe1ee4dd6a35c5335bf2bf
|
| |
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: Ie950878817b9c80cc9c970e1a84880c9b9ab228a
|
|\| |
|